Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tailscale: support split DNS endpoints #78

Merged
merged 1 commit into from
Apr 29, 2024

Conversation

mpminardi
Copy link
Contributor

@mpminardi mpminardi commented Apr 24, 2024

Support the GET/PATCH/PUT /api/v2/tailnet/{tailnetID}/dns/split-dns endpoints for reading, updating, and replacing split DNS settings for a given tailnet respectively.

Updates https://github.com/tailscale/corp/issues/19483

@mpminardi mpminardi self-assigned this Apr 24, 2024
@mpminardi
Copy link
Contributor Author

mpminardi commented Apr 24, 2024

TODO:

  • wait for endpoint to be deployed

@mpminardi mpminardi force-pushed the mpminardi/split-dns-endpoint branch 2 times, most recently from f476d66 to afc20ab Compare April 25, 2024 21:06
@mpminardi mpminardi changed the title tailscale: support split DNS endpoint tailscale: support split DNS endpoints Apr 25, 2024
tailscale/client.go Outdated Show resolved Hide resolved
tailscale/client.go Outdated Show resolved Hide resolved
@mpminardi mpminardi marked this pull request as ready for review April 25, 2024 21:10
tailscale/client.go Outdated Show resolved Hide resolved
@mpminardi mpminardi force-pushed the mpminardi/split-dns-endpoint branch 2 times, most recently from 765f4df to ea09d8c Compare April 29, 2024 19:25
tailscale/client.go Outdated Show resolved Hide resolved
tailscale/client.go Outdated Show resolved Hide resolved
tailscale/client.go Outdated Show resolved Hide resolved
tailscale/client.go Outdated Show resolved Hide resolved
@mpminardi mpminardi force-pushed the mpminardi/split-dns-endpoint branch from ea09d8c to 594a732 Compare April 29, 2024 21:21
Support the GET/PATCH/PUT `/api/v2/tailnet/{tailnetID}/dns/split-dns`
endpoints for reading, updating, and replacing split DNS settings for a
given tailnet respectively.

Updates tailscale/corp#19483

Signed-off-by: Mario Minardi <mario@tailscale.com>
@mpminardi mpminardi force-pushed the mpminardi/split-dns-endpoint branch from 594a732 to ed07c35 Compare April 29, 2024 22:02
@mpminardi mpminardi merged commit 488fd69 into main Apr 29, 2024
2 checks passed
@mpminardi mpminardi deleted the mpminardi/split-dns-endpoint branch April 29, 2024 22:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants