You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
logtail/logtail.go:235:5: var clientSentinelPrefix is unused (U1000)
logtail/logtail.go:238:2: const noSentinel is unused (U1000)
logtail/logtail.go:239:2: const stopSentinel is unused (U1000)
logtail/logtail.go:246:6: func newSentinel is unused (U1000)
logtail/logtail.go:260:6: func readSentinel is unused (U1000)
logtail/logtail.go:346:5: var errHasLogtail is unused (U1000)
Pushed to #23 for a sanity check with code's author.
ipn/ipnserver/server.go:88:2: this value of ctx is never used (SA4006)
I'm tired but I think this is a roundabout way of ensuring that ctx, cancel are always initialized in the following loop, with contortions imposed by Go's shadowing rules. Correct solution is to refactor that whole bit, which will happen because I want to support multiple frontends to a single backend. So maybe we just lint:ignore this until it gets removed.
safesocket/basic_test.go:20:2: the goroutine calls T.Fatal, which must be called in the same goroutine as the test (SA2002)
safesocket/basic_test.go:20:2: the goroutine calls T.Fatalf, which must be called in the same goroutine as the test (SA2002)
Legit logic error in the test. Needs to be refactored such that the failure bubbles up in the correct way.
staticcheck is currently very mad at our code, so we can't add it to CI.
┆Issue is synchronized with this Asana task by Unito
The text was updated successfully, but these errors were encountered: