Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update ci triggers #142

Merged
merged 2 commits into from
Aug 29, 2022
Merged

Update ci triggers #142

merged 2 commits into from
Aug 29, 2022

Conversation

mayakacz
Copy link
Contributor

What this PR does / why we need it: Updates CI triggers

Which issue this PR fixes (use fixes #<issue number>(, fixes #<issue_number>, ...) format, will close that issue when PR gets merged):

Special notes for your reviewer:

- Run on main instead of master. Updates #140
- Run on (and so not block) markdown changes, like #138 and #139
@mayakacz
Copy link
Contributor Author

I don't know how to fix the meta issue of running CI on this

Comment on lines 3 to 8
push:
paths:
- '**.go'
- '**.mod'
- '**.sum'
branches:
- master
- main
pull_request:
paths:
- '**.go'
- '**.mod'
- '**.sum'
branches:
- main
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the reason the CI isn't running now is because this part of the workflow spec will only run for pull requests that have a branch named main. I think what you want instead is:

on:
  push:
    branches:
    - main
   pull_request: {}

This will trigger the CI for all pushes to main and all pull requests that are opened/synced etc.

@mayakacz mayakacz merged commit 3424c4a into main Aug 29, 2022
@mayakacz mayakacz deleted the mayakacz-ci branch August 29, 2022 22:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants