docs: Document how to configure an exit node #279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
knyar
reviewed
Nov 13, 2023
Comment on lines
+27
to
+34
| "0.0.0.0/0", | ||
| "::/0" |
There was a problem hiding this comment.
This makes this example unrealistic, since it does not quite make sense to announce 0/0 alongside more specific subnets.
May I suggest to leave the existing node intact, and add another tailscale_device_subnet_routes block here that would just have two 0/0 routes, providing an example of an exit node?
There was a problem hiding this comment.
Good point, I have adjusted the example accordingly
Even though it makes sense, it took quite a bit of figuring-out to do, so hopefully this saves someone else some time. Signed-off-by: Manuel Hutter <manuel@hutter.io>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents how to automatically approve a device to be used as an exit node.
Even though it makes sense, it took quite a bit of figuring-out to do, so hopefully this saves someone else some time.
PS: As someone who never developed their own Terraform plugin, the contribution docs could also need some love, or at least a Makefile target on how to update the docs after a change :)