Support hujson for ACL files #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit swaps all uses of `encoding/json` with `tailscale/hujson`. This allows users of the provider to have a hujson file locally that contains all the features such as comments and trailing commas. When the ACL is pushed to tailscale via the provider, the comments will be lost when encoding/decoding is done into the `ACL` type. However, the source of truth for the ACL will be local along with the terraform configuration files, so this should not be a problem. Closes #17 Signed-off-by: David Bond <davidsbond93@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit swaps all uses of
encoding/jsonwithtailscale/hujson. This allows users of the providerto have a hujson file locally that contains all the features such as comments and trailing commas.
When the ACL is pushed to tailscale via the provider, the comments will be lost when encoding/decoding
is done into the
ACLtype. However, the source of truth for the ACL will be local along with the terraformconfiguration files, so this should not be a problem.
Closes #17
Signed-off-by: David Bond davidsbond93@gmail.com