allow overriding tailscaled transport #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bradfitz
approved these changes
Jun 8, 2024
tscert.go
Outdated
| tsClient = &http.Client{ | ||
| Transport: &http.Transport{ | ||
| if TailscaledTransport == nil { | ||
| TailscaledTransport = &http.Transport{ |
There was a problem hiding this comment.
This package global's fine and defining its nil to mean automatic is fine, but let's not write back to this global.
tr := TrailscaledTransport
if tr == nil {
tr = &http.Transport{DialContext: TailscaledDialer}
}
tsClient = &http.Client{Transport: tr}
This allows callers an alternative to overriding the tailcaled dialer. Updates tailscale/caddy-tailscale#66 Signed-off-by: Will Norris <will@tailscale.com>
willnorris
force-pushed
the
will/transport
branch
from
34704db
to
085fbf0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows callers an alternative to overriding the tailcaled dialer.
Example of how this will be used can be seen in tailscale/caddy-tailscale#67
Updates tailscale/caddy-tailscale#66