Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

opencost struct types update #1004

Merged
merged 2 commits into from
Sep 27, 2023

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Sep 27, 2023

Problem

All Opencost fields are float64 in their structs and number in swagger. Using int on our end may cause issues.

ref:-

Solution

Converted all int fields to float64 in opencost costdata struct.

Changes Made

  • Added the references as code comments
  • Converted all int fields to float64 in the relevant struct.
  • Added more fields which might be useful in the future

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy
@AvineshTripathi

Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mlabouardy mlabouardy added this to the v3.1.1 milestone Sep 27, 2023
@mlabouardy mlabouardy merged commit 642cd33 into tailwarden:develop Sep 27, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants