fix: improve dependency graph design and layout #1011
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… graphs look better
Traxmaxx
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi and
greghub
as code owners
shivam-sharma7
approved these changes
Sep 30, 2023
Traxmaxx
changed the title
|
I added some more improvements based on feedback from @AllieMendes and @jakepage91 (thanks a lot 🙏) Show full name on hover and also show relation type on hovering edges. Additionally we now show the total resource count in the bottom left corner and there's a tooltip which explains we just display AWS infrastructure for the interim period. |
|
@Traxmaxx This is amazing |
shivam-sharma7
approved these changes
Oct 2, 2023
mlabouardy
approved these changes
Oct 2, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Bigger graphs look a little bit odd sometimes and I want to get closer to the original designs
Solution
I changes some of the layout parameters (coent-bilkent) to get closer to the designs when rendering the graph.
Before:
after:
Changes Made
See diff
How to Test
[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]
Screenshots
[Include screenshots, if relevant, to help reviewers understand the changes you made.]
Notes
[Any additional notes or information that you would like to share with the reviewers.]
Checklist
Reviewers
@[username of the reviewer]