Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: prevent redirecting when not visiting the onboarding wizard #1032

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

Traxmaxx
Copy link
Contributor

@Traxmaxx Traxmaxx commented Oct 4, 2023

Problem

We're always redirecting to /dashboard when doing a full reload.

Solution

We actually only want to redirect to /dashboard when trying to access the completed onboarding wizard. An added path check prevents unnecessary redirects.

Changes Made

  • Add check if we're actually trying to access the onboarding wizard and only then redirect based on completion status!

How to Test

Do a full reload on any page. You should stay on that page instead of getting redirected to /dashboard

Screenshots

Not needed

Notes

None

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

Code owners

@mlabouardy mlabouardy merged commit 72346a7 into develop Oct 4, 2023
3 checks passed
@mlabouardy mlabouardy deleted the fix-unnecessary-redirect branch October 4, 2023 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants