-
Notifications
You must be signed in to change notification settings - Fork 424
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/tech 1656 #1043
Feature/tech 1656 #1043
Conversation
…a properly. Also comment out the story for now
|
||
async sendFeedback(payload: FormData) { | ||
try { | ||
const res = await fetch(`${BASE_URL}/feedback`, { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a quick ask, does this EP already exist on the backend
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
komiser/internal/api/v1/endpoints.go
Line 71 in 476b273
router.POST("/feedback", api.NewFeedbackHandler) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM pending the comment I left on the endpoint availability
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you also add comments over the SVGs in feedback widget indicating what they are
{/* 👇 Decorators in Storybook also accept a function. Replace <Story/> with Story() to enable it */} | ||
{Story()} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment makes partial sense as Story()
is used. I suggest either fix the comment or drop it altogether.
I actually plan on moving them into |
If you already have this plan and it's going to be done soon, then please ignore my previous comment. The main problem that I felt was difficult to read code, any kind of fix is acceptable. |
Solution
Introduce feedback widget at Komiser dashboard
Changes Made
How to Test
Check out branch and define
DISCORD_FEEDBACK_URL
when starting the backend wich the discord hook URI. Then start the frontend and click on "Leave feedback" at the top right.Video
Screen.Recording.2023-10-10.at.17.41.09.mov
Screenshots
Notes
Feedback type is still to be added
Checklist
Reviewers
@[username of the reviewer]