Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/tech 1656 #1043

Merged
merged 15 commits into from
Oct 11, 2023
Merged

Feature/tech 1656 #1043

merged 15 commits into from
Oct 11, 2023

Conversation

Traxmaxx
Copy link
Contributor

@Traxmaxx Traxmaxx commented Oct 5, 2023

Solution

Introduce feedback widget at Komiser dashboard

Changes Made

  • Add feedback widget
  • Allow user to report an issue by capturing current screen or uploading a file
  • Allow user to share their feedback

How to Test

Check out branch and define DISCORD_FEEDBACK_URL when starting the backend wich the discord hook URI. Then start the frontend and click on "Leave feedback" at the top right.

Video

Screen.Recording.2023-10-10.at.17.41.09.mov

Screenshots

Screenshot 2023-10-10 at 17 31 46
Screenshot 2023-10-10 at 17 31 57
Screenshot 2023-10-10 at 17 33 20
Screenshot 2023-10-10 at 17 33 23
Untitled

Notes

Feedback type is still to be added

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]


async sendFeedback(payload: FormData) {
try {
const res = await fetch(`${BASE_URL}/feedback`, {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a quick ask, does this EP already exist on the backend

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

router.POST("/feedback", api.NewFeedbackHandler)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes

Copy link
Collaborator

@Kolawole99 Kolawole99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM pending the comment I left on the endpoint availability

Copy link
Collaborator

@Azanul Azanul left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add comments over the SVGs in feedback widget indicating what they are

Comment on lines 25 to 26
{/* 👇 Decorators in Storybook also accept a function. Replace <Story/> with Story() to enable it */}
{Story()}
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The comment makes partial sense as Story() is used. I suggest either fix the comment or drop it altogether.

@Traxmaxx
Copy link
Contributor Author

Could you also add comments over the SVGs in feedback widget indicating what they are

I actually plan on moving them into /icons in the next steps and then also add all of them to storybook. What do you think? There should be a common place in storybook where contributors can look up all the icons existing already

@Azanul
Copy link
Collaborator

Azanul commented Oct 11, 2023

Could you also add comments over the SVGs in feedback widget indicating what they are

I actually plan on moving them into /icons in the next steps and then also add all of them to storybook. What do you think? There should be a common place in storybook where contributors can look up all the icons existing already

If you already have this plan and it's going to be done soon, then please ignore my previous comment. The main problem that I felt was difficult to read code, any kind of fix is acceptable.

@Traxmaxx Traxmaxx merged commit a27da11 into develop Oct 11, 2023
3 checks passed
@Traxmaxx Traxmaxx deleted the feature/tech-1656 branch October 11, 2023 12:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants