Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: retrieve tags of Kinesis Data Streams #1103

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

jbleduigou
Copy link
Contributor

@jbleduigou jbleduigou commented Oct 16, 2023

Problem

So far Kinesis Data Streams had no tags, which made them being displayed is the untagged resources section.

Solution

Call the function ListTagsForStream() to retrieve the list of tags for each stream.

Changes Made

  • Updated the streams.go file to retrieve the tags

How to Test

Create a Kinesis Data Stream and assign some tags to it.

Notes

Next I will probably tackle the cost calculations for Kinesis.

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy
@AvineshTripathi

Co-authored-by: Azanul Haque <42029519+Azanul@users.noreply.github.com>
@mlabouardy mlabouardy added this to the v3.1.2 milestone Oct 17, 2023
@mlabouardy mlabouardy added the aws label Oct 17, 2023
@mlabouardy mlabouardy merged commit 4b89403 into tailwarden:develop Oct 17, 2023
2 checks passed
@jbleduigou jbleduigou deleted the kinesis-tags branch October 23, 2023 09:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants