Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: changed toast to have centralized state management and sing… #1112

Merged
merged 5 commits into from
Oct 19, 2023

Conversation

shavidze
Copy link
Contributor

…leton approach

Problem

Toasts are difficult to use and always need to be imported manually if not already

Solution

Implemented ToastProvider, typically provides the same instance of the toast management context throughout the entire application.

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@Traxmaxx

@shavidze shavidze changed the title refactor: changed toast to have centrilized state management ans sing… refactor: changed toast to have centrilized state management and sing… Oct 18, 2023
@Traxmaxx
Copy link
Contributor

hei @shavidze

thanks so much for your contribution! It looks good already but there are still Toast imports and definitions found throughout the whole application:
{toast && <Toast {...toast} dismissToast={dismissToast} />}
Is this intended?

@shavidze
Copy link
Contributor Author

hei @shavidze

thanks so much for your contribution! It looks good already but there are still Toast imports and definitions found throughout the whole application: {toast && <Toast {...toast} dismissToast={dismissToast} />} Is this intended?

hi @Traxmaxx ,no I've already updated it, I missed to remove it and insert into the provider

Copy link
Contributor

@Traxmaxx Traxmaxx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM really well done! 👏 Thanks for taking the time! 🙏

@shavidze
Copy link
Contributor Author

LGTM really well done! 👏 Thanks for taking the time! 🙏

You can always ask me for help, I'm trying to participate on the server side too 🙏

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mlabouardy mlabouardy added this to the v3.1.2 milestone Oct 19, 2023
@mlabouardy mlabouardy merged commit 8b2ead4 into tailwarden:develop Oct 19, 2023
3 checks passed
@shavidze shavidze changed the title refactor: changed toast to have centrilized state management and sing… refactor: changed toast to have centralized state management and sing… Oct 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants