Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: nil pointer scaleway #1113

Merged
merged 3 commits into from
Oct 19, 2023
Merged

fix: nil pointer scaleway #1113

merged 3 commits into from
Oct 19, 2023

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Oct 18, 2023

Problem

https://discord.com/channels/932683789384183808/1163851488288845884/1164167155835732088

INFO[2023-10-18T11:44:36+02:00] Debug logging is enabled
INFO[2023-10-18T11:44:36+02:00] Data will be stored in SQLite
INFO[2023-10-18T11:44:36+02:00] there are no new migrations to run (database is up to date)
INFO[2023-10-18T11:44:36+02:00] Komiser version: 3.0.20, commit: 5c3fe4df9497a48d9bae017193e3c73c320ade31, buildt: 1688681410
INFO[2023-10-18T11:44:36+02:00] Fetching resources workflow has started
WARN[2023-10-18T11:44:36+02:00] Newer Komiser version is available: v3.1.1
WARN[2023-10-18T11:44:36+02:00] Upgrade instructions: https://github.com/tailwarden/komiser
INFO[2023-10-18T11:44:36+02:00] Fetched resources                             account=pmw-scaleway-account provider=Scaleway resources=0 service=Function
INFO[2023-10-18T11:44:37+02:00] Fetched resources                             account=pmw-scaleway-account provider=Scaleway resources=2 service=ServerlessContainer
ERRO[2023-10-18T11:44:37+02:00] error fetching Scaleway resources             err="runtime error: invalid memory address or nil pointer dereference"

Solution

Added nil checks

Signed-off-by: Azanul <azanulhaque@gmail.com>
Copy link
Collaborator

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please change the wordings in the log.Warnln

providers/scaleway/compute/instances.go Show resolved Hide resolved
providers/scaleway/compute/instances.go Show resolved Hide resolved
providers/scaleway/compute/instances.go Outdated Show resolved Hide resolved
Signed-off-by: Azanul <azanulhaque@gmail.com>
Signed-off-by: Azanul <azanulhaque@gmail.com>
@mlabouardy mlabouardy added this to the v3.1.2 milestone Oct 19, 2023
@mlabouardy mlabouardy merged commit 8448f6b into tailwarden:develop Oct 19, 2023
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants