feat: add reusable upload component to storybook #1095 #1117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
faisal7008
requested review from
mlabouardy,
ShubhamPalriwala,
AvineshTripathi,
greghub and
Traxmaxx
as code owners
Traxmaxx
reviewed
Oct 19, 2023
| </div> | ||
| )} | ||
| {fileAttachement !== null && ( | ||
| <div className="relative h-full w-full px-6 py-5"> |
There was a problem hiding this comment.
Can we adjust the Upload component so it will accept children for the feedback screenshot functionality? It already takes care of assigning a proper file type to the Upload component.
There was a problem hiding this comment.
yes, we can do that. should i make changes and raise PR
|
Really great PR so far. Thanks for taking care of the issue! 🙏 |
mlabouardy
approved these changes
Oct 19, 2023
|
@faisal7008 can you fix the conflict so the PR can be merged please |
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
The existing Feedback widget in our application had a file upload feature that wasn’t reusable and wasn’t included in our Storybook.
fixes #1095
Solution
To address this issue, I refactored the file upload feature into its own Upload component. This new component includes all the necessary props and stylings, making it easily reusable across different parts of our application. I also ensured that the FeedbackWidget is now using this new Upload component. In addition, I added the Upload component to our Storybook. This includes all necessary variants (supporting both single and multiple file uploads)
Changes Made
Screenshots
Checklist
Reviewers
@Traxmaxx