Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remove white space and scroll #1067 #1119

Merged
merged 2 commits into from
Oct 20, 2023
Merged

feat: remove white space and scroll #1067 #1119

merged 2 commits into from
Oct 20, 2023

Conversation

hemantmm
Copy link
Contributor

Fixes: #1067

Problem

When clicked on Add Filter button triggering white space and scroll.

Solution

Just added a styling of overflow-hidden

Changes Made

  • added the feature in filter/DependendencyGraphFilter.tsx

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy mlabouardy added this to the v3.1.2 milestone Oct 20, 2023
@mlabouardy mlabouardy added the ui label Oct 20, 2023
@mlabouardy mlabouardy merged commit 32eb940 into tailwarden:develop Oct 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala Awaiting requested review from ShubhamPalriwala

@AvineshTripathi AvineshTripathi Awaiting requested review from AvineshTripathi AvineshTripathi is a code owner

@greghub greghub Awaiting requested review from greghub greghub is a code owner

@Traxmaxx Traxmaxx Awaiting requested review from Traxmaxx

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
v3.1.2
Development

Successfully merging this pull request may close these issues.

'Add filter' button triggering white space and scroll
2 participants
@hemantmm @mlabouardy