Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add gcp alloydb resource #1385

Merged
merged 3 commits into from
Mar 23, 2024
Merged

feat: add gcp alloydb resource #1385

merged 3 commits into from
Mar 23, 2024

Conversation

VanshulB
Copy link
Contributor

Problem

Need to support GCP AlloyDB Resources
fixes #1334

Solution

Added GCP AlloyDB Support

Changes Made

  • AlloyDB Support
  • Updated the Package Dependencies for the same

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@AvineshTripathi
@Azanul

AvineshTripathi
AvineshTripathi approved these changes Mar 21, 2024
View reviewed changes
Copy link
Collaborator

@AvineshTripathi AvineshTripathi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Azanul to test, rest LGTM

@Azanul
Copy link
Collaborator

Azanul commented Mar 23, 2024

@VanshulB could you run go mod tidy

@VanshulB
Copy link
Contributor Author

@VanshulB could you run go mod tidy

@Azanul done

@Azanul Azanul merged commit 5b8a014 into tailwarden:develop Mar 23, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Azanul Azanul Azanul approved these changes

@AvineshTripathi AvineshTripathi AvineshTripathi approved these changes

@mlabouardy mlabouardy Awaiting requested review from mlabouardy mlabouardy is a code owner

@greghub greghub Awaiting requested review from greghub greghub is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

GSoC Ideas list
3 participants
@VanshulB @Azanul @AvineshTripathi