Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

adding support for RDS Proxies #808

Merged
merged 5 commits into from
Jun 7, 2023
Merged

adding support for RDS Proxies #808

merged 5 commits into from
Jun 7, 2023

Conversation

AnnuCode
Copy link
Contributor

Problem

fixes #564

Solution

Adding support to collect Amazon RDS db-proxy.

Changes Made

  • added proxies.go file in the rds folder.

Notes

  • want to confirm if we can tag the RDS Proxy, this link provides more info.
  • want to find the correct format for Link in the Resources slice.

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

@AnnuCode
RDS Proxies
4164c10 
Signed-off-by: Annu Singh <annu4444.as@gmail.com>
@AnnuCode AnnuCode changed the title RDS Proxies adding support for RDS Proxies May 23, 2023
@mlabouardy
Copy link
Collaborator

@AnnuCode do you need some help for this one? :)

@mlabouardy mlabouardy added the aws label May 30, 2023
@AnnuCode
Copy link
Contributor Author

@mlabouardy Hi, can you please share the correct format of RDS Proxy url to be used as LINK in the resources slice?

@mlabouardy mlabouardy added this to the v3.0.19 milestone Jun 3, 2023
@mlabouardy
Copy link
Collaborator

@mlabouardy Hi, can you please share the correct format of RDS Proxy url to be used as LINK in the resources slice?

Hey @AnnuCode, the format is the following:
https:/REGION.console.aws.amazon.com/rds/home?region=REGION#proxies:PROXY_NAME

@mlabouardy mlabouardy changed the base branch from master to develop June 6, 2023 10:27
mlabouardy and others added 2 commits June 6, 2023 12:27
@mlabouardy
Merge branch 'develop' into feature-RDSProxy
214ad4d
@AnnuCode
updating link
24d2bbf 
Signed-off-by: Annu Singh <annu4444.as@gmail.com>
@AnnuCode AnnuCode marked this pull request as ready for review June 6, 2023 11:08
mlabouardy
mlabouardy requested changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change on copy :)

providers/aws/rds/proxies.go Outdated Show resolved Hide resolved
providers/aws/rds/proxies.go Outdated Show resolved Hide resolved
@AnnuCode
correcting Service
f7ed321 
Signed-off-by: Annu Singh <annu4444.as@gmail.com>
@AnnuCode AnnuCode requested a review from mlabouardy June 7, 2023 11:05
@mlabouardy mlabouardy requested a review from eneskaya as a code owner June 7, 2023 15:04
mlabouardy
mlabouardy approved these changes Jun 7, 2023
View reviewed changes
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mlabouardy mlabouardy merged commit 6843a99 into tailwarden:develop Jun 7, 2023
2 checks passed
@ShubhamPalriwala ShubhamPalriwala mentioned this pull request Jul 7, 2023
Closed
@AnnuCode AnnuCode mentioned this pull request Nov 21, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

@eneskaya eneskaya Awaiting requested review from eneskaya

Assignees
No one assigned
Labels
aws
Projects
None yet
Milestone
v3.0.19
Development

Successfully merging this pull request may close these issues.

Support Amazon RDS db-proxy
2 participants
@AnnuCode @mlabouardy