feat(aws): estimate aws cloudwatch costs #837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mlabouardy
requested changes
Jun 3, 2023
providers/aws/ec2/cloudwatch.go
Outdated
| AverageHoursPerMonth = 730 | ||
| ) | ||
|
|
||
| func CloudWatchAlarms(ctx context.Context, client providers.ProviderClient) ([]models.Resource, error) { |
There was a problem hiding this comment.
This is redundant with existing implementation: https://github.com/tailwarden/komiser/blob/master/providers/aws/cloudwatch/alarms.go can you move the cost calculation there :)
There was a problem hiding this comment.
Hi @mlabouardy : thanks for pointing this out, I've moved the cost calculation logic to the existing implementation of alarms.go
siddarthkay
force-pushed
the
estimate-aws-cloudwatch-cost
branch
from
0eb866d
to
908f897
Compare
mlabouardy
approved these changes
Jun 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ability to calculate and view AWS Cloudwatch cost does not exist.
Solution
This PR adds a new
cloudwatch.gofile which queries the AWS v2 Go SDK and implements support for calculating AWS cloudwatch alarm costs.An entry has also been made to
aws.goto make sureec2.CloudWatchAlarmsis included.Changes Made
fixes #415
How to Test
WIP
Screenshots
WIP
Checklist
Reviewers
@mlabouardy