Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/845 exclude component dropdown fix #848

Merged

Conversation

MouradGaa
Copy link
Contributor

Solution

fixes #845

Tests

image

Screenshots

  • before
    image
  • after
    image

Notes

Not sure if the "Apply" button should be removed and the filtering should happen upon selecting a checkbox.

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy

@ShubhamPalriwala
Copy link
Collaborator

Hey @MouradGaa, congrats on opening your first PR here! rocket

I just went through the issue you're trying to fix here and I think the aim here is to give the user the ability to exclude the "Views" they have created rather than the current implementation which is to exclude via the cloud provider.

We also plan to add a "Select all" to, by default, select all so that the user can unselect if they need to any which you have already added so that is pretty great! 🚀

Do hop on to our discord if you need any help with this, would be glad to assist further and see the feature come alive!

@mlabouardy
Copy link
Collaborator

Great job @MouradGaa 👏🏻

@mlabouardy mlabouardy merged commit 8eec5ba into tailwarden:develop Jun 14, 2023
2 checks passed
@MouradGaa MouradGaa deleted the fix/845-exclude-component-dropdown-fix branch June 15, 2023 10:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants