feat: fixed toast ui #862
feat: fixed toast ui #862
Conversation
There was a problem hiding this comment.
Thanks @Oluwaseyi3, a small change and we should be good :)
dashboard/components/toast/Toast.tsx
Outdated
| <div> | ||
| <p className="text-sm font-medium">{title}</p> | ||
| <div className="p-3"> | ||
| <p className="pb-2 text-xl font-medium">{title}</p> |
There was a problem hiding this comment.
can you revert to text-sm as the title is quite huge :)
There was a problem hiding this comment.
Alright. On it Mohamed!
There was a problem hiding this comment.
Hi @mlabouardy I set it to text-lg and it looks perfectly okay for a title. Just a bit bigger than the text body. You can check it out.
If you still want it to be reviewed pls don't hesitate to notify me
seems like CI failed due to package.json changes, could you check that @Oluwaseyi3 |
Alright. Will correct that asap |
@mlabouardy Pls you can check it out now. I updated the package.json. Let me know if the test cli passes |
Hi @mlabouardy just noticed it failed once more. I’ve installed a new package.lock. This one is in sync with the develop branch. This would work now |
There was a problem hiding this comment.
Hey @Oluwaseyi3, I can still see a lot of package-lock.json changes in the git diff hence why the build is failing due to dependency mismatch.
One suggestion for a cleaner and quicker fix would be to remove the package-lock.json from the git tracking of this PR and just add and commit the dashboard/components/toast/Toast.tsx file, this should solve it all at once and the PR should be good to merge then
On it |
All done @ShubhamPalriwala |
Problem
The icon wasn't aligned with the text in the toast UI. It also needed some padding
Changes Made
I worked on the UI based the Figma model and reconciled the differences with Tailwind CSS
Screenshots
[Include screenshots, if relevant, to help reviewers understand the changes you made.]
Reviewers
@mlabouardy