Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: resource tags length #869

Merged
merged 2 commits into from
Jun 29, 2023
Merged

fix: resource tags length #869

merged 2 commits into from
Jun 29, 2023

Conversation

knav33n
Copy link
Contributor

@knav33n knav33n commented Jun 27, 2023

Problem

844

Changes Made

  • Added relevant tailwind classes to InventoryTableTags
  • Bump tailwindcss to v3.3.2

Screenshots

844

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy

mlabouardy
mlabouardy approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good, thanks @knav33n

@mlabouardy mlabouardy added this to the v3.0.20 milestone Jun 28, 2023
@mlabouardy mlabouardy added the ui label Jun 28, 2023
@mlabouardy
Copy link
Collaborator

@knav33n before I merge, do you mind fixing the conflicts on package-lock.json?

@knav33n
Copy link
Contributor Author

knav33n commented Jun 28, 2023

@mlabouardy I've fixed the merge conflicts with package-lock.json.

ShubhamPalriwala
ShubhamPalriwala approved these changes Jun 28, 2023
View reviewed changes
Copy link
Collaborator

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot for the fix! Looks amazing and to the point! Just triggered the CI, once it passes we should be gtg!

@mlabouardy mlabouardy merged commit 317f4cd into tailwarden:develop Jun 29, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala ShubhamPalriwala approved these changes

Assignees
No one assigned
Labels
ui
Projects
None yet
Milestone
v3.0.20
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@knav33n @mlabouardy @ShubhamPalriwala