Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tooltip UI implementation #879

Merged
merged 5 commits into from
Jul 4, 2023
Merged

Conversation

Oluwaseyi3
Copy link
Contributor

I have worked on the UI implementation of the Cloud Tooltip, modelling it as seen in the Figma model. This is the result

tool

However I still need the correct svg icon since it's not available in the code

@Oluwaseyi3 @mlabouardy

@mlabouardy
Copy link
Collaborator

Nice, I'm checking 👀

Copy link
Collaborator

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Oluwaseyi3, thanks for the concise fix! 🚀

One small nit from my end that the background of the tooltip is a little on the green shade than the current blue shade. Rest all lgtm, this one small change should do it all in my opinion

@Oluwaseyi3
Copy link
Contributor Author

Hey @Oluwaseyi3, thanks for the concise fix! 🚀

One small nit from my end that the background of the tooltip is a little on the green shade than the current blue shade. Rest all lgtm, this one small change should do it all in my opinion

Alright

@Oluwaseyi3
Copy link
Contributor Author

Hey @Oluwaseyi3, thanks for the concise fix! 🚀

One small nit from my end that the background of the tooltip is a little on the green shade than the current blue shade. Rest all lgtm, this one small change should do it all in my opinion

@mlabouardy @mlabouardy I added the green shade as requested. Let me know if its good to go

were

Copy link
Collaborator

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @Oluwaseyi3 🚀 The changes look perfect! Lets get this merged yayy

@mlabouardy mlabouardy merged commit 2bed46d into tailwarden:develop Jul 4, 2023
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants