Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: collect aws rds auto backup resources #886

Merged

Conversation

siddarthkay
Copy link
Contributor

@siddarthkay siddarthkay commented Jul 8, 2023

Problem

Ability to view RDS Auto Backup Resource does not exist.

Solution

This PR adds a new providers/aws/rds/auto_backups.go file which queries the AWS Go SDK and implements support for returning RDS AutoBackups.
An entry has also been made to providers/aws/aws.go to make sure rds.AutoBackups is included

Changes Made

fixes #559

How to Test

Apply filter in Dashboard:

  • Cloud Provider is AWS
  • Cloud Service is RDS Backup
    and you should be able to see RDS Backup.

Screenshots

wip

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary -> nope

Reviewers

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Collaborator

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @siddarthkay thanks a lot for the concise and well cleaned-up PR 💯 ! The current implementation looks perfect! I just wanted to know, will you be able to add cost calculation for the Auto Backups as well? It would really help the project in getting important cost calculation up that is not directly provided in the AWS console. Let me know what you think

Reference: https://aws.amazon.com/blogs/database/demystifying-amazon-rds-backup-storage-costs/

@siddarthkay
Copy link
Contributor Author

Hey @ShubhamPalriwala : Ofcourse I can add few commits to this branch which include cost calculation.
Sorry I forgot about that! 😅

@ShubhamPalriwala
Copy link
Collaborator

Hey @siddarthkay, how's it going? let me know if you need any help here 🙌🏼 !

@siddarthkay
Copy link
Contributor Author

Hey @ShubhamPalriwala and @mlabouardy :

I did some research the other day and found that calculating the cost for backups is a bit trickier as Amazon does not charge directly for automated backups, rather the charges come from the amount of backup storage used which exceeds the size of the live database.

To calculate this cost we would need to get the size of the backups and subtract the size of the live database.
This is not very straightforward in the AWS API as I had assumed initially 😅

Maybe we should limit the scope of this PR to just adding the resource, Adding the cost could be a separate issue / PR
What do you think?

@mlabouardy
Copy link
Collaborator

Hey @ShubhamPalriwala and @mlabouardy :

I did some research the other day and found that calculating the cost for backups is a bit trickier as Amazon does not charge directly for automated backups, rather the charges come from the amount of backup storage used which exceeds the size of the live database.

To calculate this cost we would need to get the size of the backups and subtract the size of the live database. This is not very straightforward in the AWS API as I had assumed initially 😅

Maybe we should limit the scope of this PR to just adding the resource, Adding the cost could be a separate issue / PR What do you think?

Thanks for the update!
Yeah, lets. create a separate issue for the cost then :)

@siddarthkay
Copy link
Contributor Author

In that case I've just rebased this branch to latest and its ready for merge 👍🏻

@mlabouardy mlabouardy added this to the v3.1.0 milestone Jul 18, 2023
@mlabouardy mlabouardy merged commit 1c8887d into tailwarden:develop Jul 18, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Amazon RDS auto-backup
3 participants