Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(save-button): fixed save button layout #899

Merged
merged 2 commits into from
Jul 16, 2023
Merged

fix(save-button): fixed save button layout #899

merged 2 commits into from
Jul 16, 2023

Conversation

shobhitexe
Copy link
Contributor

Closes #895

Problem

The save View button was not aligned with figma design

Solution

Have transferred it to The Active filters bar as per Figma design

Changes Made

  • moved the view button component from a separate component to the children of the active component so that it will align with the active filters.
  • corrected the design and alignment of the button to match the design in Figma.

Screenshots

2023-07-14.16-20-23.mp4

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy @ShubhamPalriwala

Copy link
Collaborator

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks a ton for this fix @shobhitexe! lgtm 🚀
awaiting for @mlabouardy review and then we should be gtg

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mlabouardy mlabouardy added the ui label Jul 16, 2023
@ShubhamPalriwala ShubhamPalriwala merged commit 8f3132a into tailwarden:develop Jul 16, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move 'Save as a view' to the filter bar
3 participants