Linode lke #818 #904
Linode lke #818 #904
Conversation
professorabhay
requested review from
mlabouardy and
ShubhamPalriwala
as code owners
There was a problem hiding this comment.
LGTM thanks to @mlabouardy! 🚀
hey @professorabhay just suggested a couple of small nits (apologies for asking such small changes), once done, we can proceed and merge the PR!
providers/linode/lkepool/lke_pool.go
Outdated
| Cost: 0, | ||
| // Name: nodePool.Label, | ||
| FetchedAt: time.Now(), | ||
| CreatedAt: time.Time{}, // Update this with the actual created time. |
There was a problem hiding this comment.
can we fix this please if possible?
There was a problem hiding this comment.
I tried but not find the way to do so. Because every time I try to fetch then its give error of not defined in linodego library
There was a problem hiding this comment.
Then can we have some other identifier if possible as a name? or if you could fetch the name in some other way and parse it? because ideally we should not not have a name. Let me know if you need my hand on this!
There was a problem hiding this comment.
Ok, I'll let you know
|
Hey @professorabhay, any update on this please? If you are unable to get the node name, can you add any other identifier as a name? Because we cannot keep that field blank, we can possibly tackle the name at a later stage! Let me know once the PR is ready for review! |
Added identifier "Type" as a name
|
Hey @ShubhamPalriwala, I make the changes as you said. |
|
Okay, so can you add something like an ID to the name field of the Komiser object for a comparatively better identification? Thanks |
|
I added |
|
We donot have a standard for now so I would suggest keeping id is better, but @ShubhamPalriwala I think we should work together and write down what exactly this field in the resources should carry |
Great suggestion, happy to help with that as well :) |
Problem
#818
Checklist
Reviewers
@ShubhamPalriwala and @mlabouardy