Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(filter-tags): fix tags and button design #908

Merged
merged 2 commits into from
Aug 14, 2023
Merged

fix(filter-tags): fix tags and button design #908

merged 2 commits into from
Aug 14, 2023

Conversation

shobhitexe
Copy link
Contributor

Closes #892

Problem

The design implementation of fllter tags , buttons and dropdown is not aligned with figma design

Solution

Have modified design of components to match with figma design

Changes Made

  • fixed width of filter preview inside the adding filter container
  • fixed font weight and overall spacing in filter tags
  • modified clear filter button as per figma design
  • added hover effect to add button and clear filter

Screenshots

2023-07-29.14-48-40.mp4

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy

@ShubhamPalriwala ShubhamPalriwala added this to the v3.1.1 milestone Aug 3, 2023
ShubhamPalriwala
ShubhamPalriwala approved these changes Aug 3, 2023
View reviewed changes
Copy link
Collaborator

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the detailed fixes @shobhitexe! LGTM 🚀

@mlabouardy mlabouardy merged commit 0ea0138 into tailwarden:develop Aug 14, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala ShubhamPalriwala approved these changes

Assignees
No one assigned
Labels
frontend
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.

The filters icons doesn't match design
3 participants
@shobhitexe @mlabouardy @ShubhamPalriwala