Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixing issue#842: input fields under tags management was unreasonably large #910

Merged
merged 1 commit into from
Aug 14, 2023

Conversation

Manish4044
Copy link
Contributor

Problem

In Inventory section, under the tags management, input fields in normal state have border size larger than the design suggested.
Issue #842

Issue842

Solution

After inspecting the code, it was found that the outline-width property of the Input Components used in multiple parts of UI was 2px in normal state. For normal state, it should be 1px.

Changes Made

  • Reduced the outline-width of Input Component to 1px in active state.

Screenshots

Screenshot after the fix
Issue842After

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@mlabouardy

Copy link
Collaborator

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the quick fix @Manish4044 🚀

@Manish4044
Copy link
Contributor Author

Manish4044 commented Aug 14, 2023

Thanks @ShubhamPalriwala for the PR approval.

Auto message for PR's and Issues / Hello new contributor (pull_request) 

Can you tell me why this particular check failed?

@mlabouardy
Copy link
Collaborator

Thanks @ShubhamPalriwala for the PR approval.

Auto message for PR's and Issues / Hello new contributor (pull_request) 

Can you tell me why this particular check failed?

should be fixed :)

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR @Manish4044

@mlabouardy mlabouardy added the ui label Aug 14, 2023
@mlabouardy mlabouardy merged commit 55ec413 into tailwarden:develop Aug 14, 2023
2 of 3 checks passed
@Manish4044
Copy link
Contributor Author

Thanks for approving and merging the PR @mlabouardy. It really feels good to get the first PR merged 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants