Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added support for ELB and Listener types #926

Merged
merged 2 commits into from
Aug 28, 2023
Merged

Added support for ELB and Listener types #926

merged 2 commits into from
Aug 28, 2023

Conversation

pavangudiwada
Copy link
Contributor

@pavangudiwada pavangudiwada commented Aug 25, 2023 •
edited

Problem

Fixes #539 #538 #537 #536

Solution

  • Updated code to show the different types of ELB and Listeners based on loadbalancer.Type

Changes Made

  • Added support to view different types of ELB's and Listeners

How to Test

  1. Make sure your AWS account has AWS Application/Network/Gateway ELB
  2. Build and run this branch
  3. Choose ELB Application/Network/Gateway as the service filter option
  4. Follow step 3 but pick listeners.

Screenshots

image

Notes

Need help testing Network and Gateway loadbalancer options

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

ShubhamPalriwala
ShubhamPalriwala approved these changes Aug 26, 2023
View reviewed changes
Copy link
Collaborator

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work @pavangudiwada 🚀! Love the clean and to-the-point work with minimal changes! LGTM

@mlabouardy mlabouardy added the aws label Aug 27, 2023
@mlabouardy mlabouardy added this to the v3.1.1 milestone Aug 27, 2023
@mlabouardy mlabouardy merged commit 3b62065 into tailwarden:develop Aug 28, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala ShubhamPalriwala approved these changes

@AvineshTripathi AvineshTripathi Awaiting requested review from AvineshTripathi AvineshTripathi is a code owner

Assignees
No one assigned
Labels
aws
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.

Support Amazon Elastic Load Balancing loadbalancer/net
3 participants
@pavangudiwada @mlabouardy @ShubhamPalriwala