Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove some warning in CI #950

Merged
merged 1 commit into from
Sep 9, 2023

Conversation

shivam-sharma7
Copy link
Contributor

Problem

remove warning in CI: https://github.com/tailwarden/komiser/actions/runs/5984338315/job/16235397277#step:5:38

31:4  Warning: Delete `,`  prettier/prettier
57:5  Warning: Unexpected console statement.  no-console

./components/onboarding-wizard/DatabasePurplin.tsx
10:25  Warning: Replace `l-12·-mb-14` with `b-14·-ml-12`  prettier/prettier

./components/onboarding-wizard/PurplinCloud.tsx
15:32  Warning: Replace `top-[53%]·left-[48` with `left-[48%]·top-[53`  prettier/prettier

./components/onboarding-wizard/SelectInput.tsx
[38](https://github.com/tailwarden/komiser/actions/runs/5984338315/job/16235397277#step:5:39):49  Warning: Replace `right-4⏎········bottom-[1.15rem]` with `bottom-[1.15rem]⏎········right-4`  prettier/prettier
52:110  Warning: Replace `t-[0.75rem]·pb-[0.75rem]·pl-4·pr-16` with `b-[0.75rem]·pl-4·pr-16·pt-[0.75rem]`  prettier/prettier
64:1[47](https://github.com/tailwarden/komiser/actions/runs/5984338315/job/16235397277#step:5:48)  Warning: Replace `y-2·px-3` with `x-3·py-2`  prettier/prettier
72:[51](https://github.com/tailwarden/komiser/actions/runs/5984338315/job/16235397277#step:5:52)  Warning: Replace `y-2·px-3` with `x-3·py-2`  prettier/prettier

./components/select/Select.tsx
57:147  Warning: Replace `y-2·px-3` with `x-3·py-2`  prettier/prettier

[Provide a brief description of the problem that you are trying to solve with this pull request.]

Solution

[Provide a detailed explanation of the solution you are proposing, including any relevant code snippets or screenshots.]

Changes Made

  • [List the changes you made in this pull request, including any new features or bug fixes.]

How to Test

[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]

Screenshots

[Include screenshots, if relevant, to help reviewers understand the changes you made.]

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@AvineshTripathi @mlabouardy

Copy link
Collaborator

@ShubhamPalriwala ShubhamPalriwala left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks 🚀

@mlabouardy mlabouardy added the ui label Sep 9, 2023
@mlabouardy mlabouardy added this to the v3.1.1 milestone Sep 9, 2023
@mlabouardy mlabouardy merged commit 74f6eb7 into tailwarden:develop Sep 9, 2023
3 checks passed
@shivam-sharma7 shivam-sharma7 deleted the remove-warnigs branch September 9, 2023 16:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants