Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bigquery table cost calculation #984

Merged
merged 2 commits into from
Sep 21, 2023
Merged

Bigquery table cost calculation #984

merged 2 commits into from
Sep 21, 2023

Conversation

Azanul
Copy link
Collaborator

@Azanul Azanul commented Sep 21, 2023 •
edited

Problem

Issue #784

Solution

Cost for bigquery table is dependant on the storage class of the table and if table hasn't been modified in 90 days then it's in longterm storage else it's in active storage.

ref: BigQuery Table pricing

Changes Made

  • Added function for fetching storage class based pricing
  • Added function to determine storage class

Notes

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

@Azanul
BigQuery table cost calculation
bce744e 
Signed-off-by: Azanul <azanulhaque@gmail.com>
@Azanul Azanul marked this pull request as ready for review September 21, 2023 15:11
mlabouardy
mlabouardy approved these changes Sep 21, 2023
View reviewed changes
Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Azanul

@mlabouardy mlabouardy added the gcp label Sep 21, 2023
@mlabouardy mlabouardy added this to the v3.1.1 milestone Sep 21, 2023
@mlabouardy mlabouardy merged commit af51eb2 into tailwarden:develop Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mlabouardy mlabouardy mlabouardy approved these changes

@ShubhamPalriwala ShubhamPalriwala Awaiting requested review from ShubhamPalriwala

@AvineshTripathi AvineshTripathi Awaiting requested review from AvineshTripathi AvineshTripathi is a code owner

Assignees
No one assigned
Labels
gcp
Projects
None yet
Milestone
v3.1.1
Development

Successfully merging this pull request may close these issues.

[TECH-1199] Calculate cost for GCP BigQuery Tables
2 participants
@Azanul @mlabouardy