Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow user to connect multiple cloud accounts #989

Merged
merged 15 commits into from
Oct 4, 2023

Conversation

greghub
Copy link
Collaborator

@greghub greghub commented Sep 22, 2023

Problem

Users cannot add cloud accounts during onboarding

Solution

Add/complete the flow for adding cloud accounts during onboarding

Changes Made

  • [List the changes you made in this pull request, including any new features or bug fixes.]

How to Test

[Provide instructions on how to test the changes you made, including any relevant details like configuration steps or data to be used for testing.]

Screenshots

[Include screenshots, if relevant, to help reviewers understand the changes you made.]

Notes

[Any additional notes or information that you would like to share with the reviewers.]

Checklist

  • Code follows the contributing guidelines
  • Changes have been thoroughly tested
  • Documentation has been updated, if necessary
  • Any dependencies have been added to the project, if necessary

Reviewers

@[username of the reviewer]

@greghub greghub force-pushed the feature/tech-1644 branch 3 times, most recently from 0e8d350 to ad95798 Compare September 29, 2023 04:46
@greghub greghub marked this pull request as ready for review September 29, 2023 04:48
@greghub
Copy link
Collaborator Author

greghub commented Sep 29, 2023

@mlabouardy please check if the payloads are correct (you can do it in dashboard/utils/cloudAccountHelpers.ts).

Also, a few things are missing since I didn't know what to put there:

  • Correct placeholder values resembling real API keys for MongoDB atlas and Scaleway
  • Descriptions for Scaleway, Tencent, Linode, and MongoDB onboarding pages

@Traxmaxx
Copy link
Contributor

image
SQLite shows Postgres toast

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@greghub are you planning to address the above comments?

@greghub
Copy link
Collaborator Author

greghub commented Oct 3, 2023

@mlabouardy all issues addressed + more fixes + more refactors. ready to review

@mlabouardy
Copy link
Collaborator

@mlabouardy all issues addressed + more fixes + more refactors. ready to review

on it :)

@greghub greghub force-pushed the feature/tech-1644 branch 4 times, most recently from 644d537 to f17667b Compare October 4, 2023 07:37
Copy link
Collaborator

@Kolawole99 Kolawole99 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@mlabouardy mlabouardy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All good!

@mlabouardy mlabouardy merged commit 1a59add into develop Oct 4, 2023
2 checks passed
@mlabouardy mlabouardy deleted the feature/tech-1644 branch October 4, 2023 09:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants