support aws iam user #991
Merged
support aws iam user #991
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
siddarthkay
requested review from
mlabouardy,
ShubhamPalriwala and
AvineshTripathi
as code owners
roblambell
added a commit
to roblambell/komiser
that referenced
this pull request
Jan 8, 2024
list users has been needed since tailwarden#991
4 tasks
Azanul
pushed a commit
that referenced
this pull request
Jan 9, 2024
* feat: add missing dynamodb action to policy.json describe table has been needed since #1111 * feat: add missing lambda action to policy.json list event source mappings has been needed since #1040 * feat: add missing iam action to policy.json list users has been needed since #991 * fix: correct s3 permission for list buckets api call listbucket iam action is for the contents of a bucket * feat: add missing code suite actions to policy.json needed since #1216, #1229, and #1228
Azanul
pushed a commit
that referenced
this pull request
Jan 9, 2024
* feat: add missing dynamodb action to policy.json describe table has been needed since #1111 * feat: add missing lambda action to policy.json list event source mappings has been needed since #1040 * feat: add missing iam action to policy.json list users has been needed since #991 * fix: correct s3 permission for list buckets api call listbucket iam action is for the contents of a bucket * feat: add missing code suite actions to policy.json needed since #1216, #1229, and #1228
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem
Ability to see AWS IAM Users did not exist
Solution
This PR adds a new
user.gofile which queries the AWS v2 Go SDK and implements support for calculating AWS IAM Users.An entry has also been made to
aws.goto make sureiam.Usersis included.Changes Made
fixes #547
How to Test
Open Dashboard and apply relevant filters to see iam users
Screenshots
Checklist
Reviewers
@mlabouardy @jakepage91