fix: Simulate a device that supports video #37
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
clara-jr
changed the title
hoegertn
approved these changes
Feb 27, 2023
hoegertn
approved these changes
Feb 27, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using the condition
.withInterfaces({ video: true }).build()to build a request does not make thehandlerInput.requestEnvelope.context.Viewport.videoto be truthy in order to simulate a device that does support video. It only changes the value ofhandlerInput.requestEnvelope.context.System.device.supportedInterfaces.VideoApp.The
Viewport.videoproperty represents an object including an array ofcodecsthat contains the available technologies for playing video on the device. If it does not support playing videos, theViewport.videoproperty is not present. To simulate a device that does support playing video it should be enough to make that property exist (or be truthy). In this PR, this property has been set to contain an array with all the possiblecodecsthat the output device could support.Here's the related issue: