Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review getWithVariables function when passing more than one string. #263

Closed
mateuswetah opened this issue May 24, 2019 · 0 comments

Comments

@mateuswetah
Copy link
Contributor

commented May 24, 2019

Current getWithVariables function, which mimics WordPress logic of translation with multiple string variables has some issues, we might wanna look more details about replacing regex expressions instead of only using it to remove the variables.

@mateuswetah mateuswetah created this issue from a note in tainacan/tainacan (Backlog) May 24, 2019

@mateuswetah mateuswetah self-assigned this May 24, 2019

tainacan/tainacan automation moved this from Backlog to Done May 30, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
1 participant
You can’t perform that action at this time.