Feat: implement new command EXZINTER and EXZINTERSTORE. #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: RinChanNOWWW <hzy427@gmail.com>
chenyang8094
reviewed
Jul 1, 2022
| @@ -2108,6 +2183,8 @@ int Module_CreateCommands(RedisModuleCtx *ctx) { | |||
| CREATE_WRCMD("exzremrangebyscore", TairZsetTypeZremrangebyscore_RedisCommand) | |||
| CREATE_WRCMD("exzremrangebyrank", TairZsetTypeZremrangebyrank_RedisCommand) | |||
| CREATE_WRCMD("exzremrangebylex", TairZsetTypeZremrangebylex_RedisCommand) | |||
| CREATE_WRCMD("exzunionstore", TairZsetTypeZunionstore_RedisCommand) | |||
| CREATE_WRCMD("exzinterstore", TairZsetTypeZinterstore_RedisCommand) | |||
chenyang8094
reviewed
Jul 1, 2022
| @@ -2108,6 +2183,8 @@ int Module_CreateCommands(RedisModuleCtx *ctx) { | |||
| CREATE_WRCMD("exzremrangebyscore", TairZsetTypeZremrangebyscore_RedisCommand) | |||
| CREATE_WRCMD("exzremrangebyrank", TairZsetTypeZremrangebyrank_RedisCommand) | |||
| CREATE_WRCMD("exzremrangebylex", TairZsetTypeZremrangebylex_RedisCommand) | |||
| CREATE_WRCMD("exzunionstore", TairZsetTypeZunionstore_RedisCommand) | |||
| CREATE_WRCMD("exzinterstore", TairZsetTypeZinterstore_RedisCommand) | |||
There was a problem hiding this comment.
我也疏忽了，写成Readonly命令竟然运行起来没问题
There was a problem hiding this comment.
写命令如果误写成RO命令，在master上执行基本没啥区别，但是在slave上就有不同了。slave默认是只读的，所以这个被误标记为RO的写命令也将可写，从而可能造成主备不一致。
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: RinChanNOWWW hzy427@gmail.com
Summary
related issues: #4
Implementation reference: Redis 6.2