New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

A bug in the code. #14

Open

JacksonGL opened this issue May 3, 2017 · 0 comments

JacksonGL commented May 3, 2017

There is probably a bug here.

if (sixbits[3] >= 0x40) {
	decode64.length -= 1;  // no side effect
	if (sixbits[2] >= 0x40) {
		decode64.length -= 1; // no side effect
	}
}

decode64 is a primitive string value. Decreasing its length property has no side effect: it won't throw away the last character.

The text was updated successfully, but these errors were encountered:

Uzlopak mentioned this issue

Update base64.js #15

Closed

Uzlopak mentioned this issue

Update base64.js #19

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment