Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: change in hash generation method for FILE_ID #28

Merged
merged 3 commits into from Aug 25, 2023
Merged

Conversation

taishinaritomi
Copy link
Owner

@taishinaritomi taishinaritomi commented Aug 25, 2023

Due to the build environment, the hash value was changing. To address this issue, I've changed it to use the relative_path instead of the absolute_path. Additionally, to ensure uniqueness, I've appended the packageName to the hash.

Before

FILE_ID = hash(absolute_path)

After

FILE_ID = hash(package_name + relative_path)

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2023

🦋 Changeset detected

Latest commit: 591f89f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@excss/compiler Patch
excss Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@taishinaritomi taishinaritomi merged commit 2f59bf8 into main Aug 25, 2023
1 check passed
@taishinaritomi taishinaritomi deleted the hash branch August 25, 2023 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant