新手嘗試重構 #7
Merged
新手嘗試重構 #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
不用客氣 🙂 我大概拉下來跑了一下，結果看起來是對的，讚 👍 看來你很快就看懂我在寫什麼鬼東西 XDD 有些 style 小地方我們可以討論一下 |
| if (line.startsWith("# subgroup: ")) flag = true | ||
| } | ||
| } | ||
| return lines |
There was a problem hiding this comment.
同上，How about lines.toList()
src/main/kotlin/net/purefunc/generate/util/ValidEmojiCollector.kt
Outdated
Show resolved
Hide resolved
src/main/kotlin/net/purefunc/generate/util/ValidEmojiCollector.kt
Outdated
Show resolved
Hide resolved
|
Vincent 大大早安，我剛剛依照你的 review 再做了一些重構，再麻煩妳看看 😺 祝你有美好的一天 |
|
LGTM, Let's merge. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Vincent 大大晚安，我嘗試重構了 emoji-jvm-string 的專案，主要是將原本 main 方法拆分成三部分，並將這三者分別開成 class：
另外就是將一些函數替換成
（我自己判斷）更有語意的函數來呼叫，功能完全不變；我也嘗試實作 extension function，希望可以讓閱讀程式碼上能夠更流暢。由於我 Kotlin 還在學習，感覺是班門弄斧，如果有甚麼地方可以做得更好請多指教 😺
非常感謝
祝你有美好的一天！