Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Constrained Highlight/Mark Broken #2

Closed
3 tasks done
tajmone opened this issue Nov 15, 2020 · 0 comments
Closed
3 tasks done

Constrained Highlight/Mark Broken #2

tajmone opened this issue Nov 15, 2020 · 0 comments
Labels
🎨 mark Markup: mark ⛔ broken Syntax element not parsing correctly ⛔ disabled Syntax element temporarily disabled due to conflicts

Comments

@tajmone
Copy link
Owner

tajmone commented Nov 15, 2020 •
edited
Loading

  • Add tests for constrained mark element.
  • Try and understand better the problem. (it just works now, maybe the problem was elsewhere)
  • Fix the syntax.

The constrained mark element (mark) had to be temporarily disabled because it was causing major documents disruptions (this element was possibly the main problem in the original syntax).

The problem affects the constrained variant only; the unconstrained mark element (mark_double) is still enabled, tested for, and working fine.

  ##################
  # MARK CONSTRAINED
  ##################
  # Was: "MARK"
  # Marked text (constrained variant).
  # Examples:
  #   #Lorem ipsum# dolor
  #   [red]#Lorem ipsum# dolor

From my annotated comments, it seems that the problem is in the optional "start with attribute" definition, which matches wildly.

References
@tajmone tajmone added ⛔ disabled Syntax element temporarily disabled due to conflicts ⛔ broken Syntax element not parsing correctly 🎨 mark Markup: mark labels Nov 15, 2020
@tajmone tajmone changed the title Constrained Mark Broken Constrained Highlight/Mark Broken Jul 30, 2021
tajmone added a commit that referenced this issue Jul 30, 2021
@tajmone
Test Docs: Update Links
b3115c4 
Update all ref.links to Asciidoctor docs in the test files, since the
docs have now changed URLs (the old links were still being redirected,
but the new ones are better).

Also make all those links target a new browser tab.

Improve the Marked/Highlight tests, splitting between constrained and
unconstrained examples and tests, although currently the constrained
version is suppressed in the syntax, so the constrained examples are
not currently being tested for scoping (see #2).
tajmone added a commit that referenced this issue Jul 30, 2021
@tajmone
Improve Constrained Marked/Highlight
8b7c53c 
Tweak RegEx to ensure opening delimiter is not preceded by `&`,
which can false-positively match HTML entities, breaking the document
since it won't find a closing delimiter -- and if it does, it would be
wrong anyway. (see #2)

Polish syntax comments, to make them shorter.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
🎨 mark Markup: mark ⛔ broken Syntax element not parsing correctly ⛔ disabled Syntax element temporarily disabled due to conflicts
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@tajmone