Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

§6.3: Bug in Character Script Example #61

Closed
4 of 5 tasks
Tracked by #69
tajmone opened this issue Mar 1, 2020 · 1 comment
Closed
4 of 5 tasks
Tracked by #69

§6.3: Bug in Character Script Example #61

tajmone opened this issue Mar 1, 2020 · 1 comment
Labels
📚 CHANGELOG Documenting changes between releases 📋 Roody Notes From @roodyyogurt annotated PDF of Hugo Book 🕐 add to changes Contents changes that need to be documented 💀 bug Something isn't working
Projects
v1.1.0

Comments

@tajmone
Copy link
Owner

tajmone commented Mar 1, 2020 •
edited
Loading

  • Get @tessman approval for these changes.
  • Fix document source.
  • Document the changes in CHANGES.md.
  • Document in ChangeLog.
  • Update commented annotation in source file.

Regarding the character script example in §6.3. Scripts:

setscript[Script(ned, 4)] = &CharMove, s_obj,
                            &CharGet,  cannonball,
                            &CharMove, n_obj,
                            &CharWait, 0,
                            &CharDrop, cannonball

in his annotated PDF, @roodyyogurt commented:

should be "5" if we want to execute all steps in the script
@tajmone tajmone added 💀 bug Something isn't working 🕐 add to changes Contents changes that need to be documented 🕑 pending approval Issue requires approval by Ken Tessman 📋 Roody Notes From @roodyyogurt annotated PDF of Hugo Book 📚 CHANGELOG Documenting changes between releases labels Mar 1, 2020
@tajmone tajmone added this to To do in v1.1.0 via automation Mar 1, 2020
@tessman
Copy link
Collaborator

tessman commented Mar 7, 2020

@roodyyogurt getting all fancy with his counting and accuracy. (Yeah, 5, apparently.)

tajmone added a commit that referenced this issue Mar 7, 2020
@tajmone
§6.3: Fix Script Parameter
d233488 
* Amend the `setscript` parameter from '4' to '5' in the "Ned" character
  example of "§6.3. Scripts", in order to cover all the script steps.
* Document in `CHANGES.md`.

Changes approved by K.Tessman. (closes #61)
@tajmone tajmone removed the 🕑 pending approval Issue requires approval by Ken Tessman label Mar 7, 2020
@tajmone tajmone mentioned this issue Mar 7, 2020
Open
9 tasks
@tajmone tajmone closed this as completed Mar 7, 2020
v1.1.0 automation moved this from To do to Done Mar 7, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
📚 CHANGELOG Documenting changes between releases 📋 Roody Notes From @roodyyogurt annotated PDF of Hugo Book 🕐 add to changes Contents changes that need to be documented 💀 bug Something isn't working
Projects
v1.1.0
  
Done
Milestone
No milestone
Development

No branches or pull requests
2 participants
@tajmone @tessman