Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Respect vite envvars system #201

Closed
cloud-walker opened this issue Jul 20, 2022 · 0 comments · Fixed by #202
Closed

Respect vite envvars system #201

cloud-walker opened this issue Jul 20, 2022 · 0 comments · Fixed by #202
Labels
enhancement New feature or request

Comments

@cloud-walker
Copy link

Is your feature request related to a problem? Please describe.
This is a followup from discord: https://discord.com/channels/800938406691209236/800938406691209239/998652911821262878

I need to build ladle with different envvars between multiple modes, and I expect ladle to work like Vite (explained in their docs: https://vitejs.dev/guide/env-and-mode.html#env-variables-and-modes), so, if for example I have the following files:

  • .env.development
  • .env.test
  • .env.staging
  • .env.production

Ladle should pick the right envvars from the right file and maybe support the --mode flag like vite does? 🤔
@cloud-walker cloud-walker added the needs triage needs to be reviewed label Jul 20, 2022
@tajo tajo added enhancement New feature or request and removed needs triage needs to be reviewed labels Jul 21, 2022
@tajo tajo mentioned this issue Jul 21, 2022
Merged
akx added a commit to akx/ladle that referenced this issue Jul 22, 2022
@akx
Add --base and --mode options
68f183b 
This allows doing `ladle build --base=/my-project/`, for e.g. building Ladle storybooks to GitHub Pages,
as well as overriding `--mode`, if needed (see tajo#201).
akx added a commit to akx/ladle that referenced this issue Jul 22, 2022
@akx
Add --base and --mode options
c4565e0 
This allows doing `ladle build --base=/my-project/`, for e.g. building Ladle storybooks to GitHub Pages,
as well as overriding `--mode`, if needed (see tajo#201).
akx added a commit to akx/ladle that referenced this issue Jul 22, 2022
@akx
Add --base and --mode options
9ba27f5 
This allows doing `ladle build --base=/my-project/`, for e.g. building Ladle storybooks to GitHub Pages,
as well as overriding `--mode`, if needed (see tajo#201).
akx added a commit to akx/ladle that referenced this issue Jul 26, 2022
@akx
Add --base and --mode options
cc72ec8 
This allows doing `ladle build --base=/my-project/`, for e.g. building Ladle storybooks to GitHub Pages,
as well as overriding `--mode`, if needed (see tajo#201).
@tajo tajo closed this as completed in #202 Aug 2, 2022
tajo pushed a commit that referenced this issue Aug 2, 2022
@akx
Add --base and --mode options (#202)
7fcdc97 
* Refactor triplicate CLI config application code

* Remove unused BuildParams type, rename DevParams to CLIParams

* Explicitly name CLI ladle

* Update CLI examples in docs

* Add --base and --mode options

This allows doing `ladle build --base=/my-project/`, for e.g. building Ladle storybooks to GitHub Pages,
as well as overriding `--mode`, if needed (see #201).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add --base and --mode options akx/ladle
2 participants
@cloud-walker @tajo