-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expose more events #20
Comments
I am open to this. Agreed that this doesn't add any bulk to the library; however, it increases the API surface so not taking this lightly.
Willing to open a PR, update the documentation and add some tests? :) |
Hi @tajo |
@EternallLight sure, thanks! |
Any update on this ? |
There doesn't seem to be much traction / strong need. Closing for now. Happy to discuss additions later if people have good use-cases. |
I appreciate your focus on minimalism and sticking to just the essentials! It's a great library. I'm wondering if any of the following additions would make the cut to be added?
onDragEnd
event that fires regardless of whether a change occurs or not. I'm usingbeforeDrag
to track when dragging is actually occurring and customizing the UI. But I need custom logic to determine when it stops.clientX
andclientY
positions as part of thebeforeDrag
event.onMove
event that includesclientX
andclientY
. I think 2&3 would allow for greater customization without adding any bulk to the library. Personally, I'd like to use 2&3 to change the cursor to a grabber only once the item has been dragged > 5px. Why? Because it's clickable until it's been dragged a few pixels (similar to Trello drag and drop).The text was updated successfully, but these errors were encountered: