fix: use cloneElement instead of div.openByClickOn

[imevro]

It's all because box model in CSS.

div by default holds 100% width and as you see, my toggle-portal-button actually is not a button, it's a div.

---

So this PR fixes it by using React.cloneElement for extends this.props.openByClickOn-element with onClick prop and button became a button :)

[tajo]

This is great! I've been once trying to solve the exact same thing (but unsuccessfully). :-)

Can you please update this PR, so it's passing Travis CI? Unfortunately, I just completely changed the whole build process (check the readme/contribution or package.json scripts). The repo was also force pushed (history cleaning). Thank you!

[imevro]

Can you give me an idea how to fix this test?

I don't have experience with React testing, to be honest, and don't know how to use enzyme.

The test fails because now <Portal> doesn't contain button, a button is a top-level element in Portal. Probably we need fix spec for something like button is a top-level element of <Portal />?

[imevro]

@tajo ?

[petejodo]

@theaqua you have a couple options. Check out the docs for enzyme. You could use the wrapper.is(selector) method possibly

[brianespinosa]

Nice. This keeps the markup more clean too. Hopefully the PR gets merged soon. Great work, @theaqua .

[imevro]

Hey, @tajo, I changed spec for using .text instead of .contains (https://github.com/theaqua/react-portal/commit/96044a3ba88bcbc694011f60517ec63844b8923e). Is it acceptable?

[tajo]

Looking good. Thanks!