Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Request #24

Merged
merged 4 commits into from Oct 21, 2014
Merged

Request #24

merged 4 commits into from Oct 21, 2014

Conversation

ghost
Copy link

@ghost ghost commented Oct 14, 2014

First of all, thanks for doing the way I imagined the hardmode should be (:

I did some refactoring in variables, just organizing the code.
HardOn and HardOff is confusing, let the toggle do all the things, unifying.
The way a changed the messages solves the request 23.

I think that if you want some plugin, it must be loaded automatically and that's the way most of the plugins work. Also, the messages tell the hardmode is enabled by default.

I added insert keys because sometimes I end up pressing the arrows keys for the habit of others applications - its a shame not every application is vim-like ):
And its nice for who is learning hjkl, or just wanna put another prohibited key in insert mode.

Thanks!

@takac
Copy link
Owner

takac commented Oct 17, 2014

Thanks for the work, the clean up looks good. However you change the default back to what they were originally otherwise this change is going to break lots of people's config when they update. Could you also add back the 2 on/off commands. Thanks for your help :)

@ghost
Copy link
Author

ghost commented Oct 17, 2014

Ok, I'll remake the commits.

I agree this will break people's config, but for curiosity, this makes sense to you? Plugin off by default (and why you changed it?) and the two maps on/off which does the same as one map toggle (in my vision). Thanks for the reply.

@takac
Copy link
Owner

takac commented Oct 19, 2014

The reason I have it off by default is because it is a very annoying plugin :) It allows you to help modify your Vim behaviour but for day to day use it can be very invasive. I normally have it off and enable it to practice my Vim more. I'm sure other people use it in completely different ways but I want to keep the defaults.

As for the on off commands, they provide an unambiguous command which you can run just to make sure everything is the way you want it. The amounts times I have tried to disable a plugin but instead turned it on using the 'toggle' has changed the way I write my plugins.

@ghost
Copy link
Author

ghost commented Oct 21, 2014

Fixed. This toggle problem is really annoying for sure :p
Thanks

takac added a commit that referenced this pull request Oct 21, 2014
Refactoring and improvements
@takac takac merged commit b401c72 into takac:master Oct 21, 2014
@takac
Copy link
Owner

takac commented Oct 21, 2014

Looks good to me, thanks for the work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant