Fix an issue retaining previous test reports

takahirom · Oct 24, 2023 · e798ddc · e798ddc
1 parent 83dc793
commit e798ddc
Showing 1 changed file with 6 additions and 5 deletions.
diff --git a/...ld/roborazzi-gradle-plugin/src/main/java/io/github/takahirom/roborazzi/RoborazziPlugin.kt b/...ld/roborazzi-gradle-plugin/src/main/java/io/github/takahirom/roborazzi/RoborazziPlugin.kt
@@ -7,8 +7,6 @@ import com.android.build.gradle.internal.cxx.logging.ThreadLoggingEnvironment
 import com.github.takahirom.roborazzi.CaptureResult
 import com.github.takahirom.roborazzi.CaptureResults
 import com.github.takahirom.roborazzi.RoborazziReportConst
-import java.util.Locale
-import javax.inject.Inject
 import org.gradle.api.DefaultTask
 import org.gradle.api.Plugin
 import org.gradle.api.Project
@@ -24,6 +22,8 @@ import org.gradle.api.tasks.testing.Test
 import org.gradle.language.base.plugins.LifecycleBasePlugin.VERIFICATION_GROUP
 import org.jetbrains.kotlin.gradle.dsl.KotlinMultiplatformExtension
 import org.jetbrains.kotlin.gradle.targets.jvm.KotlinJvmTarget
+import java.util.*
+import javax.inject.Inject
 
 private const val DEFAULT_OUTPUT_DIR = "outputs/roborazzi"
 private const val DEFAULT_TEMP_DIR = "intermediates/roborazzi"
@@ -205,9 +205,10 @@ class RoborazziPlugin : Plugin<Project> {
               test.systemProperties["roborazzi.test.verify"] =
                 isVerifyRun.get() || isVerifyAndRecordRun.get()
             }
-            if (test.systemProperties["roborazzi.test.compare"]?.toString()
-                ?.toBoolean() == true
-            ) {
+            val isRoborazziRun =
+              (isAnyTaskRun(isRecordRun, isVerifyRun, isVerifyAndRecordRun, isCompareRun)
+                || hasRoborazziTaskProperty(roborazziProperties))
+            if (!isRoborazziRun) {
               resultsDir.deleteRecursively()
               resultsDir.mkdirs()
             }