Alter the default output directory for comparison images and incorporate outputDirectoryPath into the comparison options #128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ate outputDirectoryPath into the comparison options
|
Snapshot diff report
|
takahirom
force-pushed
the
takahirom/change-default-output-directory-for-compare-and-actual-images-and-make-it-customizable/2023-07-22
branch
from
546c2ef
to
dfb5af7
Compare
takahirom
deleted the
takahirom/change-default-output-directory-for-compare-and-actual-images-and-make-it-customizable/2023-07-22
branch
|
👍 I was just reading the discussion in #125 and I was expecting this PR to be able to set 2 different output directories? One for the compare task and a different dir for the record task. Is this not the case? (only see changes in |
|
Think I've worked it out, the |
github-merge-queue bot
pushed a commit
to slackhq/circuit
that referenced
this pull request
Sep 18, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | plugin | minor | `1.4.0` -> `1.5.0` | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.4.0` -> `1.5.0` | | [io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.4.0` -> `1.5.0` | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.4.0` -> `1.5.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary> ### [`v1.5.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.5.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.4.0...1.5.0) ##### Changes from 1.4.x ##### Breaking Change⚠️ When specifying the file path for output, the baseline (golden or reference) images will be saved at the specified location. However, images such as \*\_compare.png will now be saved in a different directory, specifically under build/outputs/roborazzi. This update, spotted by [@​simonwalter](https://togithub.com/simonwalter), helps prevent accidental commits of \*\_compare.png images to GitHub by users who only wish to save the baseline images. Users have the ability to revert the changed path by utilizing the outputDirectoryPath setting in RoborazziOptions' CompareOptions.For more information, check out the summar[takahirom/roborazzi#125 (comment) ##### Bug Fix 🛠 We have addressed an issue where tasks might unexpectedly be skipped. As a solution, we have implemented an experimental feature that utilizes Gradle's output. ##### What's Changed - Alter the default output directory for comparison images and incorporate outputDirectoryPath into the comparison options by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#128 - Add message in exception if image was not found by [@​blackbracken](https://togithub.com/blackbracken) in [takahirom/roborazzi#129 - Fix unexpected task skip using `doNotCacheIf` by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#130 - Extract RoborazziOptions for readability by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#132 - Improve report message by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#133 - Fix crash when the component size is zero and improve performance by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#134 - Fix condition of bitmap crop by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#135 ##### New Contributors - [@​blackbracken](https://togithub.com/blackbracken) made their first contribution in [takahirom/roborazzi#129 **Full Changelog**: takahirom/roborazzi@1.4.0-rc-1...1.5.0-rc-1 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNi45Ni4zIiwidXBkYXRlZEluVmVyIjoiMzYuOTYuMyIsInRhcmdldEJyYW5jaCI6Im1haW4ifQ==-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#125