Use 'verify' task when specifying both 'compare' and 'verify' #269
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-merge-queue bot
pushed a commit
to slackhq/circuit
that referenced
this pull request
Mar 18, 2024
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | plugin | minor | `1.10.1` -> `1.11.0` | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.10.1` -> `1.11.0` | | [io.github.takahirom.roborazzi:roborazzi-compose](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.10.1` -> `1.11.0` | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.10.1` -> `1.11.0` | --- > [!WARNING] > Some dependencies could not be looked up. Check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>takahirom/roborazzi (io.github.takahirom.roborazzi)</summary> ### [`v1.11.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.11.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.10.1...1.11.0) ##### New feature In Roborazzi, if you specify outputDir in the Gradle settings, you can use [the build cache](https://togithub.com/takahirom/roborazzi?tab=readme-ov-file#q-my-tests-are-being-skipped-or-conversely-are-being-run-when-they-should-be-skipped-how-can-i-handle-caching-to-address-this). Now, Roborazzi passes the setting into the test. build.gradle roborazzi { outputDir = "src/your/screenshot/folder" } [gradle.propeties](https://togithub.com/takahirom/roborazzi?tab=readme-ov-file#roborazzirecordfilepathstrategy) roborazzi.record.filePathStrategy=relativePathFromRoborazziContextOutputDirectory Test captureRoboImage() -> saved src/your/screenshot/folder/package.class.method.png captureRoboImage("test.png") -> saved src/your/screenshot/folder/test.png ##### What's Changed - Add helpful error message for class cast exception by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#267 - Use 'verify' task when specifying both 'compare' and 'verify' by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#269 - Respect gradle build dir for reports by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#270 - Add "The images taken from Roborazzi seem broken" FAQ by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#277 **Full Changelog**: takahirom/roborazzi@1.10.1...1.11.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNy4yNTIuMCIsInVwZGF0ZWRJblZlciI6IjM3LjI1Mi4wIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although using both 'compare' and 'verify' simultaneously is not supported, it may not be intuitive for the task to default to 'compare'. Therefore, I have configured it to prioritize 'verify'.
close #268