Update device definitions #56
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Follow up from #47 (comment) |
|
👀 |
|
There is at least one bug with, with logic for round/notround. |
|
I've just updated the settings to make sure GitHub Actions runs on your PR. When you have a moment, could you please rebase from the main branch and push your changes again? |
|
Your PR looks good so far. I'll be taking a closer look at it tomorrow to review it in more detail. Thanks for your contribution! |
|
Could you please use a new wear device? 👀 e: /Users/runner/work/roborazzi/roborazzi/app/src/test/java/com/github/takahirom/roborazzi/sample/ComposeSetContentTest.kt: (35, 44): Unresolved reference: WearOSRound
|
takahirom
approved these changes
May 2, 2023
| const val Pixel6Pro = "w411dp-h891dp-normal-long-notround-any-560dpi-keyshidden-nonav" | ||
| const val Pixel6a = "w411dp-h914dp-normal-long-notround-any-420dpi-keyshidden-nonav" | ||
| const val Pixel7Pro = "w411dp-h891dp-normal-long-notround-any-560dpi-keyshidden-nonav" | ||
| const val Pixel7 = "w411dp-h914dp-normal-long-notround-any-420dpi-keyshidden-nonav" |
There was a problem hiding this comment.
Great! This will allow us to use the new devices!
| get() = if (hardware.screen.screenRatio == "long") "long" else "notlong" | ||
|
|
||
| val shape: String | ||
| get() = if (bootProps?.bootProps?.find { it.propName == "ro.emulator.circular" }?.propValue == "true") |
| appendLine( | ||
| val deviceTypes = runBlocking { readAllDevices() }.groupBy { it.tagId } | ||
|
|
||
| FileSystem.SYSTEM.write("../roborazzi/src/main/java/com/github/takahirom/roborazzi/RobolectricDeviceQualifiers.kt".toPath()) { |
roborazzi/src/test/java/com/github/takahirom/roborazzi/GenerateQualifiersTest.kt
Outdated
Show resolved
Hide resolved
takahirom
reviewed
May 2, 2023
| ) { | ||
| val qualifier: String |
slack-oss-bot
added a commit
to slackhq/circuit
that referenced
this pull request
May 31, 2023
This PR contains the following updates: | Package | Type | Update | Change | |---|---|---|---| | [io.github.takahirom.roborazzi](https://togithub.com/takahirom/roborazzi) | plugin | minor | `1.1.0` -> `1.2.0` | | [io.github.takahirom.roborazzi:roborazzi-junit-rule](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.1.0` -> `1.2.0` | | [io.github.takahirom.roborazzi:roborazzi](https://togithub.com/takahirom/roborazzi) | dependencies | minor | `1.1.0` -> `1.2.0` | --- ### ⚠ Dependency Lookup Warnings ⚠ Warnings were logged while processing this repo. Please check the Dependency Dashboard for more information. --- ### Release Notes <details> <summary>takahirom/roborazzi</summary> ### [`v1.2.0`](https://togithub.com/takahirom/roborazzi/releases/tag/1.2.0) [Compare Source](https://togithub.com/takahirom/roborazzi/compare/1.1.0...1.2.0) Breaking changes from 1.1.0⚠️ Breaking change: This is a change that affects the verify and compare tasks because the default image format was changed to support transparent images.⚠️ Breaking change: We now use a transparent background for the Composable lambda captureRoboImage(). To use the old implementation, refer to [takahirom/roborazzi#70 (comment). ##### What's Changed - Support image pixel type and make ARGB\_8888 the default value. by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#48 - Add robolectric device qualifiers by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#49 - Fix Compose gif by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#52 - Add pull request trigger for forked PR by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#58 - Update device definitions by [@​yschimke](https://togithub.com/yschimke) in [takahirom/roborazzi#56 - \[CI]Add unchanged test workflow by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#59 - Fix bug captureRoboLastImage does not run when verifying and comparing by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#61 - Add accessibility dump by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#55 - Add an IDE icon. by [@​yschimke](https://togithub.com/yschimke) in [takahirom/roborazzi#64 - Refactor and reduce Gradle Plugin logic by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#69 - Use transparent theme for compose lambda by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#70 - Add sample workflow link to README by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#71 - Introduce new workflows by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#72 - Fix GitHubActions path by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#73 - Add RoborazziRule.Options.outputFileProvider by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#74 - Save the actual image when comparing and verifying by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#51 - Add verifyAndRecordRoborazzi task by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#81 - Fix shellcheck problems by [@​takahirom](https://togithub.com/takahirom) in [takahirom/roborazzi#82 **Full Changelog**: takahirom/roborazzi@1.1.0...1.2.0 </details> --- ### Configuration 📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox. 🔕 **Ignore**: Close this PR and you won't be reminded about these updates again. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://togithub.com/renovatebot/renovate). <!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzNS4xMDUuMSIsInVwZGF0ZWRJblZlciI6IjM1LjEwNS4xIiwidGFyZ2V0QnJhbmNoIjoibWFpbiJ9-->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change the source, download on the fly and attempt to use Ktor serialization.