Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow write to ppuctrl even in the first 30k cycles since poweron/reset #61

Merged
merged 1 commit into from
Dec 5, 2019
Merged

Allow write to ppuctrl even in the first 30k cycles since poweron/reset #61

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions src/ppu.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -353,9 +353,12 @@ impl Ppu {
0x2000 => {
// Ignore the write to this register
// for about 30k cycles after power/reset.
if self.frame == 0 && self.scanline <= 88 {
return;
}
// But I found some test roms writes to 0x2000
// right after power on so commenting out so far.

//if self.frame == 0 && self.scanline <= 88 {
// return;
//}

let previousNmiEnabled = self.ppuctrl.is_nmi_enabled();
self.ppuctrl.store(value);
Expand Down