Skip to content
This repository has been archived by the owner on Mar 3, 2023. It is now read-only.

bugfix https and proxy authentication #7

Closed
wants to merge 2 commits into from
Closed

bugfix https and proxy authentication #7

wants to merge 2 commits into from

Conversation

slatequarry
Copy link

No description provided.

@jvanzyl
Copy link
Contributor

jvanzyl commented Jan 18, 2016

Needs a test, preferably one that shows the issue that your patch fixes. Also you need to match the formatting.

@atanasenko
Copy link
Contributor

This is actually the thing that generates some amount of emails on m2e lists about proxy authentication failures. Here's a corresponding bugzilla [1].
I've checked several versions of okhttp (2.3.0, 2.5.0, 2.7.2 and even latest 3.0.1) and they all just throw an IOException with this message when creating an ssl tunnel to https proxy which returns status 407.

[1] https://bugs.eclipse.org/bugs/show_bug.cgi?id=477893

@atanasenko
Copy link
Contributor

Another fix possibility is adding Proxy-Authentication preemptively.

@jvanzyl
Copy link
Contributor

jvanzyl commented Jan 23, 2016

Fix by @atanasenko with 5b500c6

@jvanzyl jvanzyl closed this Jan 23, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants